add resolve option for custom modal #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cgoessen Can you please resolve the merge conflicts. |
|
hi, I'll update my pull request when I know it works. |
|
Thank you |
|
Looks like there still are some conflicts |
|
Can you please resolve any conflicts so we can review and get this merged in. |
|
I'll see what I can do. I don't have the project on which I was working on at that time. |
|
Guess we can close this then or merge it in if the conflicts are resolved? Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added 'resolve' as the last param and kept data for legacy support.
My use case is to use the same controller for full page and modal, which requires to have a few promises resolved in both.